Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mima #2656

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Update mima #2656

merged 2 commits into from
Aug 27, 2019
+16 −17

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Aug 21, 2019 •
edited
Loading

Needs release of mima

Some exclusions needed to be adapted due to the change in lightbend-labs/mima#362

@raboof
Update mima
c227341 
Needs release of mima
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Aug 21, 2019
@akka-ci
Copy link

akka-ci commented Aug 21, 2019

Test FAILed.

@raboof raboof mentioned this pull request Aug 21, 2019
Merged
@raboof
Copy link
Contributor Author

raboof commented Aug 21, 2019

preferably also with lightbend-labs/mima#378

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Aug 23, 2019
@akka-ci
Copy link

akka-ci commented Aug 23, 2019

Test PASSed.

@raboof raboof marked this pull request as ready for review August 23, 2019 07:50
jrudolph
jrudolph approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good if we had more fine-grained controls over exclusions some times but since these exclusions are not against the latest version anyway, I guess we wouldn't care too much for now.

akka-http-core/src/main/mima-filters/10.1.8.backwards.excludes Show resolved Hide resolved
@jrudolph jrudolph merged commit 91cc2d6 into master Aug 27, 2019
@jrudolph jrudolph deleted the update-mimax branch August 27, 2019 09:50
@jrudolph jrudolph added this to the 10.1.10 milestone Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@raboof @akka-ci @jrudolph @johanandren